[PATCH] D135975: [BranchRelaxation] Fix test for duplicate branch instruction

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 23:09:16 PST 2022


foad added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/branch-relax-no-terminators.mir:100
   ; CHECK-NEXT:   S_BRANCH %bb.4
+  ; CHECK-NOT:    S_BRANCH %bb.4
   ; CHECK-NEXT: {{  $}}
----------------
gandhi21299 wrote:
> foad wrote:
> > This won't survive the next time someone regenerates the checks for this file.
> Should I get rid of that specific line then?
That already happened when I regenerated the checks for D140012. But it wasn't doing anything useful anyway because it was surrounded by CHECK-NEXT lines which would have failed if an extra S_BRANCH instruction appeared.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135975/new/

https://reviews.llvm.org/D135975



More information about the llvm-commits mailing list