[PATCH] D139993: [LoopFusion] Sorting of undominated FusionCandidates crashes
Mikael Holmén via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 14 22:33:00 PST 2022
uabelho added inline comments.
================
Comment at: llvm/test/Transforms/LoopFusion/undominated_loops.ll:1
+; RUN: opt -S -passes=loop-simplify,newgvn,loop-fusion -pass-remarks-analysis=loop-fusion -disable-output < %s 2>&1 | FileCheck %s
+
----------------
aeubanks wrote:
> can you get the IR right before loop-fusion? generally we don't want to run multiple passes in a test because that makes it more confusing
> (this smells like newgvn isn't properly returning when it invalidates the domtree rather than a loop-fusion issue, but I could be wrong)
Note that there are two reproducers in the ticket. The one I added in
https://github.com/llvm/llvm-project/issues/56263#issuecomment-1316748908
just requires
```
opt -passes="loop-fusion"
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139993/new/
https://reviews.llvm.org/D139993
More information about the llvm-commits
mailing list