[PATCH] D140045: [X86] Move RDFLAGS/WRFLAGS expansion until after RA
Phoebe Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 14 22:04:38 PST 2022
pengfei added inline comments.
================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:5075-5076
+ get(Is64Bit ? X86::PUSHF64 : X86::PUSHF32))
+ .addReg(X86::EFLAGS, RegState::Undef)
+ .addReg(X86::DF, RegState::Undef);
+ MIB->setDesc(get(Is64Bit ? X86::POP64r : X86::POP32r));
----------------
pengfei wrote:
> void wrote:
> > arsenm wrote:
> > > Are these not reserved?
> > Dunno. I'm going off of what the original code was doing...
> I think this might be a problem for PostRA.
Sorry, I misunderstood the question. Please ignore.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140045/new/
https://reviews.llvm.org/D140045
More information about the llvm-commits
mailing list