[PATCH] D140045: [X86] Move RDFLAGS/WRFLAGS expansion until after RA

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.td:1389
 
-let mayLoad = 1, mayStore = 1, usesCustomInserter = 1,
+let isPseudo = 1, mayLoad = 1, mayStore = 1, usesCustomInserter = 1,
     SchedRW = [WriteRMW], Defs = [ESP] in {
----------------
pengfei wrote:
> pengfei wrote:
> > craig.topper wrote:
> > > pengfei wrote:
> > > > Seems not needed.
> > > I think it's need to make expandPostRAPseudo get called.
> > It just checks `isPseudo` https://github.com/llvm/llvm-project/blob/main/llvm/lib/CodeGen/ExpandPostRAPseudos.cpp#L199-L203
> I mean `usesCustomInserter = 1` is not needed since the code is removed from EmitInstrWithCustomInserter.
Agreed. usesCustomInserter can be removed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140045/new/

https://reviews.llvm.org/D140045