[PATCH] D137360: [Linker] Remove nocallback attribute while linking

[Gulfem Savrun Yeniceri via Phabricator via llvm-commits]

gulfem updated this revision to Diff 483016.
gulfem added a comment.

1. Remove dropping memory(inaccessiblemem) attribute
2. Keep nocallback attribute in intrinsics
3. Drop nocallback attribute on definitions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137360/new/

https://reviews.llvm.org/D137360

Files:
  llvm/lib/Linker/LinkModules.cpp
  llvm/test/Linker/Inputs/drop-attribute.ll
  llvm/test/Linker/drop-attribute.ll


Index: llvm/test/Linker/drop-attribute.ll
===================================================================
--- /dev/null
+++ llvm/test/Linker/drop-attribute.ll
@@ -0,0 +1,33 @@
+; RUN: llvm-link %s %p/Inputs/drop-attribute.ll -S -o - | FileCheck %s
+
+; Test case that checks that nocallback attribute is dropped during linking.
+
+; CHECK: define i32 @main()
+define i32 @main() {
+entry:
+  call void @test_nocallback_definition()
+  call float @llvm.sqrt.f32(float undef)
+  call void @test_nocallback_declaration_definition_not_linked_in()
+  call void @test_nocallback_declaration_definition_linked_in()
+  ret i32 0
+}
+
+; Test that checks that nocallback attribute on a definition is dropped.
+; CHECK: define void @test_nocallback_definition()
+define void @test_nocallback_definition() nocallback {
+  ret void
+}
+
+; Test that checks that nocallback attribute on an intrinsic is NOT dropped.
+; CHECK: ; Function Attrs: nocallback nofree nosync nounwind speculatable willreturn
+; CHECK-NEXT: declare float @llvm.sqrt.f32(float) #0
+declare float @llvm.sqrt.f32(float) nocallback
+
+; Test that checks that nocallback attribute on a declaration when a definition is not linked in is dropped.
+; CHECK: declare void @test_nocallback_declaration_definition_not_linked_in(){{$}}
+declare void @test_nocallback_declaration_definition_not_linked_in() nocallback
+
+; Test that checks that nocallback attribute on a declaration when a definition is linked in is dropped.
+declare void @test_nocallback_declaration_definition_linked_in() nocallback
+
+; CHECK: define void @test_nocallback_declaration_definition_linked_in()
Index: llvm/test/Linker/Inputs/drop-attribute.ll
===================================================================
--- /dev/null
+++ llvm/test/Linker/Inputs/drop-attribute.ll
@@ -0,0 +1,4 @@
+define void @test_nocallback_declaration_definition_linked_in() {
+entry:
+  ret void
+}
Index: llvm/lib/Linker/LinkModules.cpp
===================================================================
--- llvm/lib/Linker/LinkModules.cpp
+++ llvm/lib/Linker/LinkModules.cpp
@@ -379,6 +379,12 @@
        GV.hasAvailableExternallyLinkage()))
     return false;
 
+  // Drop nocallback attribute while linking because it is treated as a hint on
+  // the module level.
+  if (auto *F = dyn_cast<Function>(&GV))
+    if (!F->isIntrinsic())
+      F->removeFnAttr(llvm::Attribute::NoCallback);
+
   if (GV.isDeclaration())
     return false;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137360.483016.patch
Type: text/x-patch
Size: 2460 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221214/2222ff3d/attachment.bin>