[PATCH] D133715: [ADT] Add HashMappedTrie

Wed Dec 14 14:01:01 PST 2022

dblaikie added a comment.

In D133715#3996194 <https://reviews.llvm.org/D133715#3996194>, @dexonsmith wrote:

> In D133715#3996103 <https://reviews.llvm.org/D133715#3996103>, @dblaikie wrote:
>
>> eh, maybe string's easier to read in expect diagnostics anyway... just seems a bit awkward/circuitous/unfortunate :/ (I guess the stringification could move into the test code, implemented via such a friend relationship)
>
> I do remember the string being easy to read in expect diagnostics, FWIW.
>
> What about renaming the methods to `printLayout()` and `dumpLayout()`? Then `print()` and `dump()` would at least still be available for something user-centric.

Workable, though I'd still rather it be moved to the test file if it's not too inconvenient (with some friendship, probably). Avoid muddying the implementation with test-only features.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133715/new/

https://reviews.llvm.org/D133715