[PATCH] D139981: [EarlyIfConversion] Add target hook to allow for multiple ifcvt iterations.
Hendrik Greving via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 14 13:37:56 PST 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rGddf2f90a48b6: [EarlyIfConversion] Add target hook to allow for multiple ifcvt iterations. (authored by hgreving).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139981/new/
https://reviews.llvm.org/D139981
Files:
llvm/include/llvm/CodeGen/TargetInstrInfo.h
llvm/lib/CodeGen/EarlyIfConversion.cpp
Index: llvm/lib/CodeGen/EarlyIfConversion.cpp
===================================================================
--- llvm/lib/CodeGen/EarlyIfConversion.cpp
+++ llvm/lib/CodeGen/EarlyIfConversion.cpp
@@ -321,9 +321,15 @@
return false;
}
- // Check that instruction is predicable and that it is not already
- // predicated.
- if (!TII->isPredicable(*I) || TII->isPredicated(*I)) {
+ // Check that instruction is predicable
+ if (!TII->isPredicable(*I)) {
+ LLVM_DEBUG(dbgs() << "Isn't predicable: " << *I);
+ return false;
+ }
+
+ // Check that instruction is not already predicated.
+ if (TII->isPredicated(*I) && !TII->canPredicatePredicatedInstr(*I)) {
+ LLVM_DEBUG(dbgs() << "Is already predicated: " << *I);
return false;
}
Index: llvm/include/llvm/CodeGen/TargetInstrInfo.h
===================================================================
--- llvm/include/llvm/CodeGen/TargetInstrInfo.h
+++ llvm/include/llvm/CodeGen/TargetInstrInfo.h
@@ -1464,6 +1464,13 @@
/// Returns true if the instruction is already predicated.
virtual bool isPredicated(const MachineInstr &MI) const { return false; }
+ /// Assumes the instruction is already predicated and returns true if the
+ /// instruction can be predicated again.
+ virtual bool canPredicatePredicatedInstr(const MachineInstr &MI) const {
+ assert(isPredicated(MI) && "Instruction is not predicated");
+ return false;
+ }
+
// Returns a MIRPrinter comment for this machine operand.
virtual std::string
createMIROperandComment(const MachineInstr &MI, const MachineOperand &Op,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139981.482979.patch
Type: text/x-patch
Size: 1624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221214/541ee0a3/attachment.bin>
More information about the llvm-commits
mailing list