[PATCH] D133715: [ADT] Add HashMappedTrie
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 14 13:00:48 PST 2022
dblaikie added a comment.
(avodiing quoting a lot)
I think the stringification's especially/sort of an unfortunate way to test this - that stringified version probably isn't how a user would want to dump the data structure (they'd want to see a user-centric view of the data structure, not the implementation details). Is it practical to at least move to friending the test from the data structure and have the test poke around in the internals to inspect the structure & assert/expect/check various things about it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133715/new/
https://reviews.llvm.org/D133715
More information about the llvm-commits
mailing list