[PATCH] D139993: [LoopFusion] Sorting of undominated FusionCandidates crashes

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:422
+    // needed.
+    bool bWrongOrder =
+        nonStrictlyPostDominate(LHSEntryBlock, RHSEntryBlock, DT, LHS.PDT);
----------------
please use LLVM coding style, local variables are CamelCase without a prefix


================
Comment at: llvm/test/Transforms/LoopFusion/undominated_loops.ll:1
+; RUN: opt -S -passes=loop-simplify,newgvn,loop-fusion -pass-remarks-analysis=loop-fusion -disable-output < %s 2>&1 | FileCheck %s
+
----------------
can you get the IR right before loop-fusion? generally we don't want to run multiple passes in a test because that makes it more confusing
(this smells like newgvn isn't properly returning when it invalidates the domtree rather than a loop-fusion issue, but I could be wrong)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139993/new/

https://reviews.llvm.org/D139993