[PATCH] D139965: [RISCV] Add a bit to TSFlags to mark SignExtendingOpW instructions for SExtWRemoval.

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

On a purely stylistic view, I prefer having the information localized in one place.  It's much easier to see the code for the transform and figure out what it does if the scope is small.  The tablegen approach requires looking at a lot more code to understand the total interaction.

Given both Alex and Craig prefer the tablegen style, I'll consider myself outvoted.  I don't care strongly about it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139965/new/

https://reviews.llvm.org/D139965