[PATCH] D139982: [IR] Adds Function::splice() member functions.

Vasileios Porpodas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 12:09:29 PST 2022


vporpo added inline comments.


================
Comment at: llvm/unittests/IR/FunctionTest.cpp:442
+  BasicBlock *ToBB2 = getBBWithName(ToF, "to_bb2");
+  BasicBlock *ToBB3 = getBBWithName(ToF, "to_bb3");
+
----------------
RKSimon wrote:
> I'm also seeing these build warnings:
> ```
> E:\llvm\llvm-project\llvm\unittests\IR\FunctionTest.cpp(442): warning C4189: 'ToBB3': local variable is initialized but not referenced
> E:\llvm\llvm-project\llvm\unittests\IR\FunctionTest.cpp(440): warning C4189: 'ToBB1': local variable is initialized but not referenced
> E:\llvm\llvm-project\llvm\unittests\IR\FunctionTest.cpp(437): warning C4189: 'FromBB3': local variable is initialized but not referenced
> ```
Just pushed the patch for these too 9eb5d9cbe9e53d16dbedf922259ae3643d919603. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139982/new/

https://reviews.llvm.org/D139982



More information about the llvm-commits mailing list