[PATCH] D138215: [AMDGPU][CodeGen] Support raw format TFE buffer loads other than byte, short and d16 ones.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4555
+    if (IsD16) {
+      assert(!IsTFE);
+      Opc = AMDGPU::G_AMDGPU_BUFFER_LOAD_FORMAT_D16;
----------------
kosarev wrote:
> arsenm wrote:
> > If this isn't supposed to work, should return false for the fallback 
> What's the fallback? From what I see if we do not stop here, it will just crash later on a less specific check not being able to legalise the call.
The legalization error is a better user facing error than hitting the assert


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138215/new/

https://reviews.llvm.org/D138215