[PATCH] D139673: [AMDGPU][SIFrameLowering] Mark VGPR used for AGPR spills as reserved

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 10:08:52 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:1173
+    if (HasUnreservedSpill) {
+      MRI.freezeReservedRegs(MF);
+      HasUnreservedSpill = false;
----------------
This is an API problem. Should add a way to incrementally add and remove reserved registers 


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:1174
+      MRI.freezeReservedRegs(MF);
+      HasUnreservedSpill = false;
+    }
----------------
Don't see why you need to clear this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139673/new/

https://reviews.llvm.org/D139673



More information about the llvm-commits mailing list