[PATCH] D139311: InstCombine: Match pattern that appears in clang's __builtin_isnormal

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 08:35:19 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1309
 
+  if (IsAnd && stripSignOnlyFPOps(LHS0) == stripSignOnlyFPOps(RHS0)) {
+    if (Value *Left = matchOrdAndUnorderedCmpInf(Builder, LHS, RHS))
----------------
arsenm wrote:
> foad wrote:
> > Do you need to worry about IsLogicalSelect here?
> I don't really know what IsLogicalSelect means
I reproduced a case from a select and alive2 seems to not have an issue with it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139311/new/

https://reviews.llvm.org/D139311



More information about the llvm-commits mailing list