[PATCH] D140006: fix jump threading failing to update cloned dbg.values

Wed Dec 14 07:45:50 PST 2022

jmorse requested changes to this revision.
jmorse added a comment.
This revision now requires changes to proceed.

In D140006#3995119 <https://reviews.llvm.org/D140006#3995119>, @Orlando wrote:

> You can iterate over the values using `DbgVariableIntrinsic::location_ops()` and you can replace them using `DbgVariableIntrinsic::replaceVariableLocationOp`.
>
> It may be acceptable to leave that as a "TODO" item - I'll leave that up to @jmorse. If it's decided to leave the patch in its current form then please take a look at the inline comment I've added.

Ah yeah, this is a good idea, and we shouldn't set the example that DIArgList dbg.values are ignorable for some reason.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140006/new/

https://reviews.llvm.org/D140006