[PATCH] D140006: fix jump threading failing to update cloned dbg.values

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

According to the style guide, "Variable names should [...] be camel case, and start with an upper case letter (e.g. Leader or Boats).", you'll need to update the variable names you've added. Otherwise all looks good.



================
Comment at: llvm/test/Transforms/JumpThreading/thread-debug-info.ll:5-6
+
+; Test that the llvm.dbg.value calls in a threaded block are correctly targeting
+; the locals in their block, and not the unthreaded one.
+define void @test2(i32 %cond1, i32 %cond2) {
----------------
I'd suggest rewording thus, to describe the action of transforming the IR, rather than the state at the end.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140006/new/

https://reviews.llvm.org/D140006