[PATCH] D139133: [SPIR-V] Support memory(...) function attributes

[Matt Arsenault via Phabricator via llvm-commits]

arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp:60
+
+  if (F.hasFnAttribute(Attribute::AttrKind::ReadNone) ||
+      MemEffects.doesNotAccessMemory())
----------------
arsenm wrote:
> ReadNone still exists? I thought it was removed. Why check it?
Oh, readnone still exists but only applies to parameters now. There's no point in checking it on a function


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139133/new/

https://reviews.llvm.org/D139133