[PATCH] D139842: [compiler-rt][X86] add half <-> x86_fp80 conversion builtins

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 05:35:47 PST 2022


t.p.northover updated this revision to Diff 482822.
t.p.northover added a comment.

Remove `COMPILER_RT_HAS_FLOAT16` check. It's actually a soft/float ABI check rather than whether to support the type entirely (at least for conversions) so it meant the new functions didn't get built on Darwin (which is still soft-float for `_Float16` compiler-rt calls for historic reasons).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139842/new/

https://reviews.llvm.org/D139842

Files:
  compiler-rt/lib/builtins/CMakeLists.txt
  compiler-rt/lib/builtins/extendhfxf2.c
  compiler-rt/lib/builtins/fp_extend.h
  compiler-rt/lib/builtins/fp_extend_impl.inc
  compiler-rt/lib/builtins/fp_lib.h
  compiler-rt/lib/builtins/fp_trunc.h
  compiler-rt/lib/builtins/fp_trunc_impl.inc
  compiler-rt/lib/builtins/truncxfhf2.c
  compiler-rt/test/builtins/Unit/extendhfxf2_test.c
  compiler-rt/test/builtins/Unit/fp_test.h
  compiler-rt/test/builtins/Unit/truncxfhf2_test.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139842.482822.patch
Type: text/x-patch
Size: 21031 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221214/969c6239/attachment.bin>


More information about the llvm-commits mailing list