[PATCH] D140005: [runtimes] Pass on COMPILER_RT_BUILD_GWP_ASAN option

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 02:58:15 PST 2022


DavidSpickett created this revision.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Currently Arm 32 bit fails to build GWP ASAN, which is fine
because you can disable it with an option.

However this was not being passed to the external project
call.

There are probably more options and functions that could
break this way but this is the one I hit building the llvm
release for Arm 32 bit.

Depends on D139536 <https://reviews.llvm.org/D139536>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140005

Files:
  llvm/runtimes/CMakeLists.txt


Index: llvm/runtimes/CMakeLists.txt
===================================================================
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -362,6 +362,7 @@
                                       -DLLVM_DEFAULT_TARGET_TRIPLE=${target}
                                       -DLLVM_ENABLE_PROJECTS_USED=${LLVM_ENABLE_PROJECTS_USED}
                                       -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=${LLVM_ENABLE_PER_TARGET_RUNTIME_DIR}
+                                      -DCOMPILER_RT_BUILD_GWP_ASAN=${COMPILER_RT_BUILD_GWP_ASAN}
                                       -DCMAKE_C_COMPILER_WORKS=ON
                                       -DCMAKE_CXX_COMPILER_WORKS=ON
                                       -DCMAKE_ASM_COMPILER_WORKS=ON


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140005.482775.patch
Type: text/x-patch
Size: 781 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221214/892545f8/attachment.bin>


More information about the llvm-commits mailing list