[PATCH] D139415: [RFC][WebAssembly] Optimize GEPs

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyOptimizeGEPs.cpp:1
+//===--- WebAssemblyOptimizeGEPs.cpp - GetElementPtr index processing ---===//
+//
----------------
Can you add a motivating example of small code snippets that tries to solve that the status quo doesn't?


================
Comment at: llvm/test/CodeGen/WebAssembly/optimize-geps.ll:6
+
+define hidden void @one_dim(ptr nocapture noundef readonly %arg, ptr nocapture noundef readonly %arg1, ptr nocapture noundef writeonly %arg2) {
+; CHECK-LABEL: @one_dim(
----------------
tlively wrote:
> samparker wrote:
> > tlively wrote:
> > > Would it be possible to have a smaller test case? It's hard to tell what to look at here.
> > Yeah, if I remove one array and move to i32 this should hopefully half the size.
> Thanks! Could you also add comments in the test input pointing out where interesting things happen?
Can we have some comments for most of the tests to help what to look at? Not sure which part of the code we need to look. Also, what is `dim`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139415/new/

https://reviews.llvm.org/D139415