[PATCH] D139368: [libunwind] Use .irp directives. NFC
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 14 00:11:02 PST 2022
MaskRay added a comment.
In D139368#3981594 <https://reviews.llvm.org/D139368#3981594>, @ldionne wrote:
> Did the libc++/libc++abi/libunwind CI run on this patch? I thought it should, but if not, we can get that setup. Otherwise, I think this is a gentle reminder for folks not to ignore CI failures :-)
I don't know a libunwind CI. I personally checked the output is the same with multiple architectures, x86_64, aarch64, arm, riscv64, ppc32 linux, ppc64 linux, etc, but I couldn't have known that this did with AIX.
Having a CI set up will provide some value but likely not very useful for many libunwind changes, but nevertheless, it is good if it can check what AIX and z/OS do since most contributors don't have access to the two.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139368/new/
https://reviews.llvm.org/D139368
More information about the llvm-commits
mailing list