[PATCH] D137360: [Linker] Remove nocallback attribute while linking

[Gulfem Savrun Yeniceri via Phabricator via llvm-commits]

gulfem marked an inline comment as done.
gulfem added a comment.

I would like to make sure that we all agree on the following items:

1. A `nocallback` `intrinsic`, where the attribute should never be dropped.

Why is the case? @nikic and @jdoerfert can you explain the reason behind this? Why should we drop `nocallback` for user declared functions, but keep it for `intrinsics`? 
We need to clarify 1).

2. A `nocallback` definition.

We are not going to allow `nocallback` on definitions, and I think we are all on the same page for 2.

3. A `nocallback` declaration with a definition that is being linked in.
4. A `nocallback` declaration without a definition being linked in.

Whether the definition is being linked in or not, we will drop the `nocallback` attribute. I think, we are all on the same page for 3 and 4 as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137360/new/

https://reviews.llvm.org/D137360