[PATCH] D130903: [AArch64][GlobalISel] Lower formal arguments of AAPCS & ms_abi variadic functions.

Tue Dec 13 15:15:29 PST 2022

mstorsjo added a comment.

In D130903#3992928 <https://reviews.llvm.org/D130903#3992928>, @mstorsjo wrote:

> In D130903#3992834 <https://reviews.llvm.org/D130903#3992834>, @dzhidzhoev wrote:
>
>> Thank you for catching it! I wonder how win64 tests didn't fail on that. The problem was that during rebase I accidentally changed CCAssignFn arguments, so that all Win64 function was treated as vararg. Fixed it now. Should I recommit?
>
> Thanks for the update! I can run a bunch of tests on it that specifically exercise calling conventions (that I don't otherwise run regularly) - I'll let you know how it fares.

The tests I had ran just fine now, thanks!

However I don't see any added test for this case - could you add that too? (I guess it's probably covered by some existing test - just extending that to run with globalisel probably is enough?)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130903/new/

https://reviews.llvm.org/D130903