[PATCH] D139631: [WebAssembly][NFC] Add ComplexPattern for loads

[Heejin Ahn via Phabricator via llvm-commits]

aheejin accepted this revision.
aheejin added a comment.

Thank you! I agree this is more readable and easier to manage.



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelDAGToDAG.cpp:317-318
+
+bool WebAssemblyDAGToDAGISel::SelectLoadOperands(MVT AddrType, unsigned ConstOpc,
+                                                 SDValue N, SDValue &Offset,
+                                                 SDValue &Addr) {
----------------
clang-format

Please clang-format patches before submitting. You can subscribe to https://reviews.llvm.org/project/view/78/ which lets you know when clang-format errors are found. One downside of that hook is, it seems to some build testing, which always seem to fail, which we don't need to care... 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139631/new/

https://reviews.llvm.org/D139631