[PATCH] D139673: [AMDGPU][SIFrameLowering] Mark VGPR used for AGPR spills as reserved

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 14:11:09 PST 2022


arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:1170
 
+    MRI.freezeReservedRegs(MF);
+
----------------
Can you only do this if we actually needed to do an allocation? It's actually pretty expensive to recompute this and we do it a few too many times as it is already


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139673/new/

https://reviews.llvm.org/D139673



More information about the llvm-commits mailing list