[PATCH] D139408: [InstCombine] Fold logic-and/logic-or by distributive laws

Tue Dec 13 13:07:03 PST 2022

lebedev.ri added a comment.

In D139408#3992943 <https://reviews.llvm.org/D139408#3992943>, @bcl5980 wrote:

> In D139408#3991865 <https://reviews.llvm.org/D139408#3991865>, @lebedev.ri wrote:
>
>> This patch is not rebased, as per the test diffs.
>
> Do you mean rGa888825aeef8d6592c6cf5f4e5854cc39af49633 <https://reviews.llvm.org/rGa888825aeef8d6592c6cf5f4e5854cc39af49633> update test will add {{[^@]+}} for every test?
> It looks latest code already revert it by rG697bfa40a3f853d8b9103ead53cd80a4f7c5a7df <https://reviews.llvm.org/rG697bfa40a3f853d8b9103ead53cd80a4f7c5a7df>.

No, i'm saying that the test diff was showing spurious/misleading changes.
As you've noted, many of those tests (e.g. `@logic_and_logic_or_1`) got handled
in another patch, but the diff was still showing as-if they weren't handled before this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139408/new/

https://reviews.llvm.org/D139408