[PATCH] D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests

Tue Dec 13 13:05:57 PST 2022

ro added a comment.

In D91620#3993001 <https://reviews.llvm.org/D91620#3993001>, @haowei wrote:

> We are seeing following test failures on Fuchsia's Clang Linux x64 builders after this change (255c3e3dcb06299aa2365f70817322a8a381c351 <https://reviews.llvm.org/rG255c3e3dcb06299aa2365f70817322a8a381c351>) landed:
>
>   MemorySanitizer-Unit :: ./Msan-x86_64-Test/34/38
>   MemorySanitizer-Unit :: ./Msan-x86_64-Test/MemorySanitizer/SelectPartial
>   MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/34/38
>   MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/MemorySanitizer/SelectPartial
>   MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/MemorySanitizer/SelectPartial

I don't see any of those.   In fact, `Msan-x86_64-Test` etc. aren't even built during my attempts, even in a vanilla tree.  Initially, this seems to have been due to the lack of `libcxx` and `libcxxabi`, but even with those no dice.  Unless someone can tell me what's wrong (or, better yet, check the differences without and with my patch), I fear there's nothing I can do.

> Profile-x86_64 :: Linux/comdat_rename.test
> Profile-x86_64 :: Linux/instrprof-show-debug-info-correlation.c
> Profile-x86_64 :: instrprof-dump.c
> Profile-x86_64 :: instrprof-write-file-only.c
> Profile-x86_64 :: instrprof-write-file.c

All of those `PASS` for me.  Again, not the slightest idea what's different in your builds.

> Link to the failed builder: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8794900470653863441/overview

At least those build logs are ways more useful than the ones from the LLVM buildbots: the latter lack all the crucial details like exact compile commands etc.

> Please take a look. And if it takes a long time to fix, could you revert this change please?

I heavly rely on the builder maintainer's help here, when none of this is reproducible on my systems.  Otherwise I'll have to give up on this patch for good.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91620/new/

https://reviews.llvm.org/D91620