[PATCH] D139679: [X86] Don't zero out %eax if both %al and %ah are used

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 12:12:06 PST 2022


void planned changes to this revision.
void added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:530-531
+  //
+  // FIXME: It would be nice if the sub_and_super iterators would iterator over
+  // sibling registers as well.
+  for (const MachineBasicBlock &MBB : MF)
----------------
arsenm wrote:
> I think you would be better off operating in terms of regunits and then going backwards to registers.
Akchewally, it looks like using RegUnits in the prologue-epilogue inserter gives us what we want. I'll change this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139679/new/

https://reviews.llvm.org/D139679



More information about the llvm-commits mailing list