[PATCH] D139656: [RISCV] Build single element vector for start of reduction change

[Philip Reames via Phabricator via llvm-commits]

reames updated this revision to Diff 482558.
reames edited the summary of this revision.
reames added a comment.

Rebase over landed changes, and request re-review.

@craig.topper Can you take a second look at this?  I think we might have been chasing a red herring on the LMUL2 and above concern for this patch.  This patch specifically only reuses VL at a callsite where we know that lmul is constrained to LMUL1 or less.  As such, I don't think we can get the over-constrained vmv.s.x issue we'd discussed in this patch.

It's definitely still a real issue which can be exercised from the insert element path, but that has changed with this patch (or the preceding patches).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139656/new/

https://reviews.llvm.org/D139656

Files:
  llvm/lib/Target/RISCV/RISCVISelLowering.cpp
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-reduction-fp.ll
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-reduction-int.ll
  llvm/test/CodeGen/RISCV/rvv/fold-binary-reduce.ll
  llvm/test/CodeGen/RISCV/rvv/vreductions-fp-sdnode.ll
  llvm/test/CodeGen/RISCV/rvv/vreductions-int.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139656.482558.patch
Type: text/x-patch
Size: 205395 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221213/e96d6f4e/attachment-0001.bin>