[PATCH] D139909: [lld-macho] Fix __objc_stubs ordering
Keith Smiley via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 13 10:12:35 PST 2022
keith added inline comments.
================
Comment at: lld/test/MachO/x86-64-objc-stubs.s:10-11
# CHECK-NEXT: _objc_msgSend$foo:
-# CHECK-NEXT: 00000001000004b8 movq 0x1b51(%rip), %rsi
-# CHECK-NEXT: 00000001000004bf jmpq *0xb3b(%rip)
+# CHECK-NEXT: 00000001000004a9 movq 0x1b60(%rip), %rsi
+# CHECK-NEXT: 00000001000004b0 jmpq *0xb4a(%rip)
----------------
int3 wrote:
> Ideally the test would've been written using substitutions instead of hardcoded addresses so we don't have this churn. It would probably also make the test more comprehensive. See start-end.s line 102 for an example of how to test RIP-relative addresses. I'm fine with this being done in some future commit though :)
Updated these and verified they passed before and after. because of that maybe they're a bit less strict than they could be
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139909/new/
https://reviews.llvm.org/D139909
More information about the llvm-commits
mailing list