[PATCH] D139120: APFloat: Add isSmallestNormalized predicate function

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 10:02:36 PST 2022


sepavloff added inline comments.


================
Comment at: llvm/unittests/ADT/APFloatTest.cpp:695
+    EXPECT_TRUE(NegSmallestNormalized.isSmallestNormalized());
+
+    for (APFloat *Val : {&PosSmallestNormalized, &NegSmallestNormalized}) {
----------------
Could you please also specify the numbers explicitly as float/double? I mean tests like:
```
EXPECT_TRUE(APFloat(0x1.0p-126F).isSmallestNormalized());
```
and similar check for double?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139120/new/

https://reviews.llvm.org/D139120



More information about the llvm-commits mailing list