[PATCH] D139718: [SLP][NFC]Inital redesign of ShuffleInstructionBuilder, NFC.

[Valeriy Dmitriev via Phabricator via llvm-commits]

vdmitrie accepted this revision.
vdmitrie added a comment.
This revision is now accepted and ready to land.

Looks good. Thanks!



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:8128-8129
+/// \code
+/// %s1 = shufflevector <2 x ty> %0, poison, <1 , 0>
+/// %s2 = shufflevector <2 x ty> %1, poison, <1 , 0>
+/// \endcode
----------------
nit: space after '1'


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:8141-8142
+/// \code
+/// %s1 = shufflevector <2 x ty> %0, poison, <1 , 0, 1, 0>
+/// %s2 = shufflevector <2 x ty> %1, poison, <1 , 0, 1, 0>
+/// \endcode
----------------
nit: space after '1'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139718/new/

https://reviews.llvm.org/D139718