[PATCH] D64833: [Xtensa 7/10] Add Xtensa instruction printer.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 08:59:39 PST 2022


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wdng.

LGTM with nit



================
Comment at: llvm/lib/Target/Xtensa/MCTargetDesc/XtensaInstPrinter.cpp:34
+  if (!(SRE = cast<MCSymbolRefExpr>(Expr)))
+    assert(false && "Unexpected MCExpr type.");
+
----------------
Also means you can get rid of the assert(false) and if


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64833/new/

https://reviews.llvm.org/D64833



More information about the llvm-commits mailing list