[PATCH] D139644: [InlineAdvisor] Allow loading advisors as plugins

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D139644#3992236 <https://reviews.llvm.org/D139644#3992236>, @IBricchi wrote:

> Right I see, well there are two targets, the first is the unit tests which uses all the files except "InlineAdvisorPlugin.cpp", and then there's the target for the inlineAdvisorPlugin which only uses "InlineAdvisorPlugin.cpp", so for the first target we need "InlineAdvisorPlugin.cpp" in the optional source, and for the second target we need everything else.

Huh. Why would you not want to run the other tests when you run the plugin advisor? If it's because those tests don't work on that target, I'd recommend making that factoring first - i.e. just the cmakelists change(s) that exclude unwanted tests from that target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139644/new/

https://reviews.llvm.org/D139644