[PATCH] D139940: [Bitcode] Remove auto-detection for typed pointers

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
nikic added a reviewer: opaque-pointers.
Herald added subscribers: ormris, jdoerfert, steven_wu, hiraditya.
Herald added a project: All.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Always read bitcode according to the `-opaque-pointers` mode. Do not perform auto-detection to implicitly switch to typed pointers.

This is a step towards removing typed pointer support, and also eliminates the class of problems where linking may fail if a typed pointer module is loaded before an opaque pointer module. (The latest place where this was encountered is https://reviews.llvm.org/D139924, but this has previously been fixed in other places doing bitcode linking as well.)

PS: This currently still fails a small handful of tests, which I'll update before landing this.


https://reviews.llvm.org/D139940

Files:
  llvm/docs/OpaquePointers.rst
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/test/Bitcode/Inputs/invalid-call-mismatched-explicit-type.bc
  llvm/test/Bitcode/Inputs/invalid-gep-mismatched-explicit-type.bc
  llvm/test/Bitcode/Inputs/invalid-gep-operator-mismatched-explicit-type.bc
  llvm/test/Bitcode/Inputs/invalid-load-mismatched-explicit-type.bc
  llvm/test/Bitcode/alloca-addrspace.ll
  llvm/test/Bitcode/arm-intrinsics.ll
  llvm/test/Bitcode/atomic-no-syncscope.ll
  llvm/test/Bitcode/atomic.ll
  llvm/test/Bitcode/atomicrmw-upgrade.ll
  llvm/test/Bitcode/attributes-3.3.ll
  llvm/test/Bitcode/byval-upgrade.test
  llvm/test/Bitcode/callbr.ll
  llvm/test/Bitcode/cmpxchg-upgrade.ll
  llvm/test/Bitcode/cmpxchg.3.6.ll
  llvm/test/Bitcode/compatibility-3.6.ll
  llvm/test/Bitcode/compatibility-3.7.ll
  llvm/test/Bitcode/compatibility-3.8.ll
  llvm/test/Bitcode/compatibility-3.9.ll
  llvm/test/Bitcode/compatibility-4.0.ll
  llvm/test/Bitcode/compatibility-5.0.ll
  llvm/test/Bitcode/compatibility-6.0.ll
  llvm/test/Bitcode/constantsTest.3.2.ll
  llvm/test/Bitcode/conversionInstructions.3.2.ll
  llvm/test/Bitcode/dityperefs-3.8.ll
  llvm/test/Bitcode/dso_location.ll
  llvm/test/Bitcode/function-address-space-fwd-decl.ll
  llvm/test/Bitcode/getelementptr-zero-indices.ll
  llvm/test/Bitcode/global-variables.3.2.ll
  llvm/test/Bitcode/highLevelStructure.3.2.ll
  llvm/test/Bitcode/inalloca-upgrade.test
  llvm/test/Bitcode/inalloca.ll
  llvm/test/Bitcode/intrinsics-struct-upgrade.ll
  llvm/test/Bitcode/intrinsics-with-unnamed-types.ll
  llvm/test/Bitcode/invalid.test
  llvm/test/Bitcode/local-linkage-default-visibility.3.4.ll
  llvm/test/Bitcode/memInstructions.3.2.ll
  llvm/test/Bitcode/metadata-2.ll
  llvm/test/Bitcode/metadata.3.5.ll
  llvm/test/Bitcode/miscInstructions.3.2.ll
  llvm/test/Bitcode/nocfivalue.ll
  llvm/test/Bitcode/objectsize-upgrade-7.0.ll
  llvm/test/Bitcode/old-aliases.ll
  llvm/test/Bitcode/select.ll
  llvm/test/Bitcode/standardCIntrinsic.3.2.ll
  llvm/test/Bitcode/terminatorInstructions.3.2.ll
  llvm/test/Bitcode/thinlto-function-summary.ll
  llvm/test/Bitcode/thinlto-summary-local-5.0.ll
  llvm/test/Bitcode/upgrade-aarch64-ldstxr.ll
  llvm/test/Bitcode/upgrade-aarch64-sve-intrinsics.ll
  llvm/test/Bitcode/upgrade-annotation.ll
  llvm/test/Bitcode/upgrade-arc-attachedcall-bundle.ll
  llvm/test/Bitcode/upgrade-arc-runtime-calls-bitcast.ll
  llvm/test/Bitcode/upgrade-arc-runtime-calls.ll
  llvm/test/Bitcode/upgrade-elementtype.ll
  llvm/test/Bitcode/upgrade-global-ctors.ll
  llvm/test/Bitcode/upgrade-global-dtors.ll
  llvm/test/Bitcode/upgrade-inline-asm-elementtype.ll
  llvm/test/Bitcode/upgrade-ptr-annotation.ll
  llvm/test/Bitcode/upgrade-tbaa.ll
  llvm/test/Bitcode/upgrade-var-annotation.ll
  llvm/test/Bitcode/variableArgumentIntrinsic.3.2.ll
  llvm/test/Bitcode/weak-cmpxchg-upgrade.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139940.482494.patch
Type: text/x-patch
Size: 282848 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221213/7b79341b/attachment-0001.bin>