[PATCH] D139644: [InlineAdvisor] Allow loading advisors as plugins

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D139644#3991463 <https://reviews.llvm.org/D139644#3991463>, @IBricchi wrote:

> The reason we need to do this is because otherwise we fail this check: https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/LLVMProcessSources.cmake#L105
>
> The check is making sure that there aren't any dead files in a folder, and it does this by making sure all files are used by all targets. However in our case we have two targets and each one uses a subset of the files so we have to use the LLVM_OPTIONAL_SOURCES to tell CMAKE that the files not being used by a given target aren't dead.

Right, but my question is why does everything get made LLVM_OPTIONAL_SOURCES and not just the subset that's not used on the specific target?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139644/new/

https://reviews.llvm.org/D139644