[PATCH] D139898: [StandardInstrumentations] Handle initial IR before checking if IR is interesting

Jamie Schmeiser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 06:27:08 PST 2022


jamieschmeiser accepted this revision.
jamieschmeiser added a comment.
This revision is now accepted and ready to land.

I was surprised that your change would require test changes--and that probably points out a bug in my initial design.  Only the TextChangeReporter unwraps the module to always use the module in handleInitialIR.  This should be lifted out to the call-site so it is consistant with all handlers.  It doesn't make sense that the initial IR changes based on filtering (ie, which one prints first).  But that is not germaine to this change so...

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139898/new/

https://reviews.llvm.org/D139898



More information about the llvm-commits mailing list