[PATCH] D139931: (WIP) [AMDGPU] Add `.workgroup_processor_mode` to v5 MD

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 06:24:07 PST 2022


kzhuravl added a comment.

Also needs a test.



================
Comment at: llvm/include/llvm/Support/AMDHSAKernelDescriptor.h:165-166
   KERNEL_CODE_PROPERTY(USES_DYNAMIC_STACK, 11, 1),
-  KERNEL_CODE_PROPERTY(RESERVED1, 12, 4),
+  KERNEL_CODE_PROPERTY(WGP_MODE, 11, 1), // GFX10+
+  KERNEL_CODE_PROPERTY(RESERVED1, 13, 3),
 };
----------------
These changes are not needed. WGP_MODE is recorded in COMPUTE_PGM_RSRC1.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:417-419
+  if (CurrentProgramInfo.WgpMode && AMDGPU::getAmdhsaCodeObjectVersion() >= 5 &&
+      MF.getSubtarget<GCNSubtarget>().getGeneration() >= GCNSubtarget::GFX10)
+    KernelCodeProperties |= amdhsa::KERNEL_CODE_PROPERTY_WGP_MODE;
----------------
These changes are not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139931/new/

https://reviews.llvm.org/D139931



More information about the llvm-commits mailing list