[PATCH] D138531: [PATCH] [NVPTX] Backend support for variadic functions

[Pavel Kopyl via Phabricator via llvm-commits]

pavelkopyl added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:2617
 
-SDValue
-NVPTXTargetLowering::getParamSymbol(SelectionDAG &DAG, int idx, EVT v) const {
+SDValue NVPTXTargetLowering::getParamSymbol(SelectionDAG &DAG, int idx, EVT v,
+                                            bool isVarArg) const {
----------------
tra wrote:
> Nit: We could define and use  `VARARG_IDX = -1` or just document that a negative index is for a vararg, instead of adding a new `isVarArg` argument. 
> The call would just use `/* vararg*/ -1` which is a slight improvement, IMO over having to use the comment *and* an extra argument.
> 
OK, done.


================
Comment at: llvm/test/CodeGen/NVPTX/vaargs.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -O0 -march=nvptx -mattr=+ptx60 -mcpu=sm_30 | FileCheck %s --check-prefixes=CHECK,CHECK32
----------------
krisb wrote:
> nit: I guess check-lines are no longer autogenerated, so it's better to remove this note.
I agree, thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138531/new/

https://reviews.llvm.org/D138531