[PATCH] D139006: [UpdateTestChecks] Match define for labels

[Sanjay Patel via Phabricator via llvm-commits]

spatel added subscribers: arsenm, spatel.
spatel added a comment.

I agree with the revert - we'd need lots of commits like this:
b7232dafe69eb04c14217 <https://reviews.llvm.org/rGb7232dafe69eb04c1421743e4bd779d6ff3853be> (cc @arsenm)

Another possibility to fix this with less churn:
Add a warning during (re-)generation for any test where the CHECK-LABEL could be going wrong. So scan the file for a call to a function name that is also defined in that file?
We already have a warning like that for variables named `%tmp`. So if a test file contains the potentially buggy construct, then warn the user that they should regenerate with "--function-signature" to be safe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139006/new/

https://reviews.llvm.org/D139006