[PATCH] D139888: [lld][ARM] support absolute thunks for Armv4T Thumb and interworking

Tue Dec 13 02:46:21 PST 2022

stuij added a comment.

In D139888#3991052 <https://reviews.llvm.org/D139888#3991052>, @MaskRay wrote:

> What are the "absolute relocations"? They usually refer to `R_ARM_ABS32` and other relocation types that are represented as `R_ABS` in lld.
>
> "linker" in the subject isn't useful. The directory is all about the linker implementation.

Thanks. Yes you're right, this is about making R_ARM_CALL and R_ARM_THUMB_CALL work with non-PIC thunks. Previously I actually had "thunks" in the subject and didn't have "linker", but then at the last minute late at night for reasons of bad judgement I guess, I decided to go with relocation and added linker :) I changed the subject to follow your suggestion.

> Does the support make GBA and NDS programs with mixed A32/T32 code linkable with lld? If yes, that'll be great... I've played many GBA/NDS games in the past...

Yes, indeed it does :) And inexplicably I didn't even bother to test-drive this code on a GBA program. But now I did and I'm staring at a red screen written by Thumb code called from Arm created by an all-LLVM toolchain :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139888/new/

https://reviews.llvm.org/D139888