[PATCH] D135997: [Dominators] check indirect branches of callbr

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 02:44:58 PST 2022


nikic added a comment.

After this change, https://github.com/llvm/llvm-project/blob/cca01df291300fb06879fca5113bc71567c64738/llvm/lib/IR/Instruction.cpp#L129 will have to be adjusted for the new semantics. The function should return nullptr for callbr, because there no longer exists any insert point after the callbr. I think callers should deal with this gracefully, but it will probably regress some optimizations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135997/new/

https://reviews.llvm.org/D135997



More information about the llvm-commits mailing list