[PATCH] D138912: [RS4GC] Rematerialize derived pointers before uses.

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

LGTM, please wait a bit for someone else to look at.



================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:2474
+
+    if (Record.Cost >= RematerializationThreshold)
+      continue;
----------------
Move above as to exit earlier?


================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:2505
+
+    LLVM_DEBUG(dbgs() << '\n');
+
----------------
looks profitable


================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:2512
+    // decreasing chain size order?
+    if (Record.ChainToBase.size() > 1) {
+      Record.ChainToBase.clear();
----------------
!empty()?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138912/new/

https://reviews.llvm.org/D138912