[PATCH] D130903: [AArch64][GlobalISel] Lower formal arguments of AAPCS & ms_abi variadic functions.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a reviewer: efriedma.
mstorsjo added a comment.

I had somewhat missed the scope of this patch - I had only expected it to affect how functions marked `ms_abi` on non-Windows platforms are lowered, while it affects all regular Windows targets too.

This caused a pretty severe regression for Windows targets, reproducible with this snippet:

  $ cat test.c
  double func(double f) {
      return f;
  }
  $ clang -target aarch64-windows -S -o - test.c -fno-asynchronous-unwind-tables
  func:
  	sub	sp, sp, #16
  	str	x0, [sp, #8]
  	ldr	d0, [sp, #8]
  	add	sp, sp, #16
  	ret

(The `-fno-asynchronous-unwind-tables` option is only relevant for clarity of the output.)

I'll go ahead and push a revert in a moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130903/new/

https://reviews.llvm.org/D130903