[PATCH] D139780: [AMDGPU] Annotate control flow on visited blocks

Ruiling, Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 23:12:52 PST 2022


ruiling added a comment.

In D139780#3990936 <https://reviews.llvm.org/D139780#3990936>, @gandhi21299 wrote:

> @ruiling `PDT.getRoot()` yields `BB4`. So for PDT with exactly one root, we should only allow the transformation when its terminator is a branch instruction?

Yes.

> This causes the following tests to fail due to insertion of dummy blocks:

I think you just need to update the test checks. It is expected there will be changes in generated code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139780/new/

https://reviews.llvm.org/D139780



More information about the llvm-commits mailing list