[PATCH] D135929: [profile] Add binary ids into indexed profiles

[Gulfem Savrun Yeniceri via Phabricator via llvm-commits]

gulfem marked 2 inline comments as done.
gulfem added inline comments.


================
Comment at: llvm/lib/ProfileData/InstrProfWriter.cpp:296-299
     // If we weren't able to add the frame mappings then it doesn't make sense
     // to try to merge the records from this profile.
     if (!addMemProfFrame(I.first, I.second, Warn))
       return;
----------------
ellis wrote:
> I'm not sure if this early return makes sense here. If we fail to merge the "frame mappings" then does that mean we should also skip merging the binary ids? I think we should either move this to its own function or move merging the binary ids before this.
Thanks for pointing that out. I moved it earlier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135929/new/

https://reviews.llvm.org/D135929