[PATCH] D139893: [RISCV] Set ShouldSignExtI32Param in TargetLibraryInfo for riscv64.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 16:47:02 PST 2022


craig.topper added a comment.

In D139893#3990451 <https://reviews.llvm.org/D139893#3990451>, @jyknight wrote:

> So, I guess these have all been getting actually miscompiled on riscv64 up till now? Whoops!

We're fairly aggressive about type legalizing i32 values via sign extension so we might accidentally get it right in a lot of cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139893/new/

https://reviews.llvm.org/D139893



More information about the llvm-commits mailing list