[PATCH] D139067: [FuzzMutate] New InsertCFGStrategy

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

lgtm with nits



================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:311
+  } while (CasesTaken.count(tmp) != 0);
+  CasesTaken.insert(tmp);
+  return tmp;
----------------
line after while


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:317
+  SmallVector<Instruction *, 32> Insts;
+  for (auto I = BB.getFirstInsertionPt(), E = BB.end(); I != E; ++I)
+    Insts.push_back(&*I);
----------------
Can do this in the constructor Insts(BB.getFirstInsertionPt(), BB.end())


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:355-356
+                    }));
+    assert(RS && "There is no integer type in all allowed types, is the "
+                 "setting correct?");
+    Type *Ty = RS.getSelection();
----------------
Assert string still weirdly phased


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139067/new/

https://reviews.llvm.org/D139067