[PATCH] D139874: [AMDGPU] Lower VGPR to physical SGPR COPY to S_MOV_B32 if VGPR contains the compile time constant
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 12 13:48:08 PST 2022
arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.
================
Comment at: llvm/lib/Target/AMDGPU/SIFixSGPRCopies.cpp:851
+ if (DefMI && DefMI->isMoveImmediate()) {
+ MachineOperand SrcConst = DefMI->getOperand(1);
+ assert(SrcConst.isImm() && "Operand should be immediate");
----------------
Don't use value MachineOperands
================
Comment at: llvm/lib/Target/AMDGPU/SIFixSGPRCopies.cpp:852
+ MachineOperand SrcConst = DefMI->getOperand(1);
+ assert(SrcConst.isImm() && "Operand should be immediate");
+ Register TmpReg =
----------------
This isn't guaranteed by isMoveImmediate
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139874/new/
https://reviews.llvm.org/D139874
More information about the llvm-commits
mailing list