[PATCH] D139871: [WebAssembly] Replace LOAD_SPLAT with SPLAT_VECTOR

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

Nice, it's good to use the builtin nodes where possible. I think we had intentionally selected splats of constants into constant vectors for performance reasons. Would you be able to preserve that behavior and make this a non-functional change?



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:64
   ImmLeaf lane_idx;
+  SDPatternOperator load_type;
   PatFrag splat;
----------------
Should this be `lane_load`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139871/new/

https://reviews.llvm.org/D139871